Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers

[Michal Simek]

+Katta, Vishal

On 1/29/26 19:46, Mark Brown wrote:
> On Thu, Jan 29, 2026 at 01:17:45PM -0500, Sean Anderson wrote:
> > On 1/29/26 13:09, Mark Brown wrote:
>
> > > > - Driver authors tend to use them even when there are hardware registers
> > > >    available with the same information, as Xilinx has not always been
> > > >    consistent in adding such registers.
>
> > > I'm not sure I follow your second point - driver authors tend to use
> > > what?
>
> > Authors look at the devicetree node and see something like
>
> > and go "Ah, there are the properties I need." On some Xilinx cores this
> > is the only way to discover certain properties, so people have gotten into
> > the habit of using them even when these properties can be read from the
> > device itself.
>
> Oh.  If the properties are there it's reasonable and sensible to use
> them, them being redundant is a concern when specifying the binding but
> once things are there any discrepency should usually be resolved in
> favour of the binding.

Let me add our driver owner of this device to answer some questions.

Katta: Can you please look at it?

Thanks,
Michal