Re: [PATCH v2 next 06/11] tools/nolibc/printf: Use bit-masks to hold requested flag, length and conversion chars

From: Willy Tarreau

Date: Sun Feb 08 2026 - 10:22:50 EST


On Fri, Feb 06, 2026 at 07:11:16PM +0000, david.laight.linux@xxxxxxxxx wrote:
> From: David Laight <david.laight.linux@xxxxxxxxx>
>
> Use flags bits (1u << (ch & 31)) for the flags, length modifiers, and
> conversion specifiers.
> This makes it easy to test for multiple values at once.
>
> Detect the conversion flags " #+-0" although they are currently all ignored.
>
> Add support for length modifiers 't' and 'z' (both long) and 'q' and 'L'
> (both long long).
>
> Add support for "%i" (the same as %d").
>
> Unconditionally generate the signed values (for %d) to remove a second
> set of checks for the size.

OK, looks good to me, and I confirm that the inflation caused by the
jump table at patch 4 is now gone.

Acked-by: Willy Tarreau <w@xxxxxx>

Willy