Re: [PATCH v3 3/9] pci: pwrctrl: rename pci-pwrctrl-slot as generic

[Neil Armstrong]

On 2/9/26 12:33, Manivannan Sadhasivam wrote:
> On Fri, Feb 06, 2026 at 03:50:31PM +0100, Neil Armstrong wrote:
> > The driver is pretty generic and would fit for either
> > PCI Slots or PCI devices connected to PCI ports, so rename
> > the driver and module as pci-pwrctrl-generic.
> >
> > Suggested-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   drivers/pci/pwrctrl/Kconfig               | 8 ++++----
> >   drivers/pci/pwrctrl/Makefile              | 4 ++--
> >   drivers/pci/pwrctrl/{slot.c => generic.c} | 0
>
> I was expecting the rename inside the driver too :)

Oh yeah, will do in v4

Neil

> - Mani
>
> >   3 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> > index e0f999f299bb..0a93ac4cd11b 100644
> > --- a/drivers/pci/pwrctrl/Kconfig
> > +++ b/drivers/pci/pwrctrl/Kconfig
> > @@ -11,12 +11,12 @@ config PCI_PWRCTRL_PWRSEQ
> >   	select POWER_SEQUENCING
> >   	select PCI_PWRCTRL
> >   
> > -config PCI_PWRCTRL_SLOT
> > -	tristate "PCI Power Control driver for PCI slots"
> > +config PCI_PWRCTRL_GENERIC
> > +	tristate "Generic PCI Power Control driver for PCI slots"
> >   	select PCI_PWRCTRL
> >   	help
> > -	  Say Y here to enable the PCI Power Control driver to control the power
> > -	  state of PCI slots.
> > +	  Say Y here to enable the generic PCI Power Control driver to control
> > +	  the power state of PCI slots.
> >   
> >   	  This is a generic driver that controls the power state of different
> >   	  PCI slots. The voltage regulators powering the rails of the PCI slots
> > diff --git a/drivers/pci/pwrctrl/Makefile b/drivers/pci/pwrctrl/Makefile
> > index 13b02282106c..f6bb4fb9a410 100644
> > --- a/drivers/pci/pwrctrl/Makefile
> > +++ b/drivers/pci/pwrctrl/Makefile
> > @@ -5,7 +5,7 @@ pci-pwrctrl-core-y			:= core.o
> >   
> >   obj-$(CONFIG_PCI_PWRCTRL_PWRSEQ)	+= pci-pwrctrl-pwrseq.o
> >   
> > -obj-$(CONFIG_PCI_PWRCTRL_SLOT)		+= pci-pwrctrl-slot.o
> > -pci-pwrctrl-slot-y			:= slot.o
> > +obj-$(CONFIG_PCI_PWRCTRL_GENERIC)	+= pci-pwrctrl-generic.o
> > +pci-pwrctrl-generic-y			:= generic.o
> >   
> >   obj-$(CONFIG_PCI_PWRCTRL_TC9563)	+= pci-pwrctrl-tc9563.o
> > diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/generic.c
> > similarity index 100%
> > rename from drivers/pci/pwrctrl/slot.c
> > rename to drivers/pci/pwrctrl/generic.c
> >
> > --
> > 2.34.1