Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR

[Marek Vasut]

On 2/10/26 4:44 PM, Frank Li wrote:
> On Mon, Feb 09, 2026 at 09:41:24PM +0100, Marek Vasut wrote:
> > On 2/9/26 8:17 PM, Frank Li wrote:
> >
> > Hello Frank,
> >
> > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > > index 75486e1b0c15f..a0adcd3fe1229 100644
> > > > --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > > +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > > @@ -201,7 +201,7 @@ &uart2 {
> > > >    	 * the speed can be increased accordingly.
> > > >    	 */
> > > >    	bluetooth: bluetooth {
> > > > -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
> > > > +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
> > >
> > > in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
> > >
> > > >    		max-speed = <3000000>;
> > > >    		vbat-supply = <&vcc_3v3>;
> > > >    		vddio-supply = <&vcc_3v3>;
> > > > @@ -222,7 +222,7 @@ &usdhc1 {
> > > >    	status = "okay";
> > > >
> > > >    	brcmf: wifi@1 {
> > > > -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
> > > > +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
> > >
> > > driver have not check "brcm,bcm43430a1-fmac".
> > >
> > > Look like driver can work for both CHIP without modify dts.
> > Sure, the driver can work even with the current DT, but the DT isn't
> > accurate as it describes compatible string specifically for the 1DX part.
> > This change makes the DT use more generic compatible which fits both 1DX and
> > 1YN parts. And it also fixes the comment accordingly.
>
> Okay, can you descript more clear at commit message, especially how driver
> can auto detect 1DX and 1YN.
This is already there, see "drop the more specific compatible string and 
let the driver auto-detect the chip type."

What would you prefer to change there ?