Re: [PATCH v3] staging: rtl8723bs: remove shadowed variable in sdio_halinit

From: Ethan Tidmore

Date: Tue Feb 10 2026 - 17:52:07 EST


On Tue Feb 10, 2026 at 12:56 PM CST, Haroen Tmimi wrote:
> The variable 'bMacPwrCtrlOn' was redeclared in the function
> CardEnable, shadowing a variable of the same name declared at the
> top of the function (line 21).
>
> Remove the redundant 'u8' type declaration to use the existing outer
> variable and resolve a -Wshadow warning.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@xxxxxxxxx>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>

Thanks,

ET