Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible

[Rob Herring]

On Wed, Feb 11, 2026 at 11:36:28AM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 11, 2026 at 11:13 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >
> > >>
> > >>  static const struct of_device_id gpio_aggregator_dt_ids[] = {
> > >> +       {
> > >> +               .compatible = "gpio-aggregator",
> > >> +       },
> > >>         {
> > >>                 .compatible = "gpio-delay",
> > >>                 .data = (void *)FWD_FEATURE_DELAY,
> > >> --
> > >> 2.43.0
> > >>
> > >
> > > Regardless of the DT bindings - this change is perfectly fine. We do
> >
> > You cannot have compatible without DT bindings, so this alone is not
> > "perfectly fine". Maybe you wanted platform_device_id entry for
> > ACPI/legacy/MFD devices?
> >
> 
> Sure you can, you just can't put it into upstream devicetree sources.
> We have had a compatible for gpio-sim for testing purposes for years.
> Why would it be illegal to enable matching of platform drivers over DT
> for testing purposes?

The primary issue is undocumented ones show up in 'make 
dt_compatible_check'. I would like that to be warning free.

Rob