Re: [PATCH 5/7] arm64: dts: mt8167: Add a specific watchdog dts node

[AngeloGioacchino Del Regno]

Il 11/02/26 20:03, Luca Leonardo Scorcia ha scritto:
> The watchdog driver for mt8167 relies on DT data, so the fallback
> compatible mt8516 won't work, need to update watchdog device node
> to sync with watchdog dt-binding document.

Sorry, what are you talking about?
You probably forgot to update the commit description after pulling this
from some midstream tree of yours ;-)

Please update the commit description.

> Signed-off-by: Luca Leonardo Scorcia <l.scorcia@xxxxxxxxx>
> ---
>   arch/arm64/boot/dts/mediatek/mt8167.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8167.dtsi b/arch/arm64/boot/dts/mediatek/mt8167.dtsi
> index fd17daa13dba..caf51f203dd3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8167.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8167.dtsi
> @@ -48,6 +48,13 @@ apmixedsys: apmixedsys@10018000 {
>   			#clock-cells = <1>;
>   		};
>   
> +		watchdog@10007000 {

All devicetree nodes must be ordered by mmio start (when they have one, or by
name when they are not addressable).

In this case, the watchdog node goes *after* the scpsys node, and before imgsys.

Cheers,
Angelo

> +			compatible = "mediatek,mt8167-wdt";
> +			reg = <0 0x10007000 0 0x1000>;
> +			interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> +			#reset-cells = <1>;
> +		};
> +
>   		scpsys: syscon@10006000 {
>   			compatible = "mediatek,mt8167-scpsys", "syscon", "simple-mfd";
>   			reg = <0 0x10006000 0 0x1000>;