RE: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes

[pritam.sutar]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Wednesday, January 28, 2026 1:07 PM
> To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>; robh@xxxxxxxxxx;
> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx;
> faraz.ata@xxxxxxxxxxx; muhammed.ali@xxxxxxxxxxx;
> selvarasu.g@xxxxxxxxxxx
> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
> nodes
> 
> On 23/01/2026 08:59, Pritam Manohar Sutar wrote:
> > Hi Krzysztof,
> >
> > Thank you for your feedback.
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: 22 January 2026 07:05 PM
> >> To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>;
> robh@xxxxxxxxxx;
> >> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx
> >> Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> >> linux- samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> >> rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx;
> faraz.ata@xxxxxxxxxxx;
> >> muhammed.ali@xxxxxxxxxxx; selvarasu.g@xxxxxxxxxxx
> >> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920:
> >> Enable USB nodes
> >>
> >> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> >>> Enable USB PHY and DWC3 USB controllers' nodes.
> >>>
> >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> >>> ---
> >>>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
> >> +++++++++++++++++++
> >>>  1 file changed, 21 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> >>> b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> >>> index f90f7704597c..5896dd69334a 100644
> >>> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> >>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> >>> @@ -160,15 +160,20 @@ &xtcxo {
> >>>  &usbdrd31_ssphy {
> >>>  	dvdd-supply = <&dummy_regulator>;
> >>>  	vdd18-supply = <&dummy_regulator>;
> >>> +	status = "okay";
> >>
> >> You just added the node in the previous patch, so why it cant be
> >> enavled there?
> >>
> >>>  };
> >>>
> >>>  &usbdrd31_hsphy {
> >>>  	dvdd-supply = <&dummy_regulator>;
> >>>  	vdd18-supply = <&dummy_regulator>;
> >>>  	vdd33-supply = <&dummy_regulator>;
> >>> +	status = "okay";
> >>>  };
> >>>
> >>>  &usbdrd31_dwc3 {
> >>> +	dr_mode = "otg";
> >>> +	usb-role-switch;
> >>> +	role-switch-default-mode = "peripheral";
> >>
> >> Why did you add incomplete node in previous commit?
> >
> > The commit was added to align with the existing convention of
> > separating node addition and enabling logic in USB configurations.
> > This approach is referenced from commits such as:
> >
> > https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55
> > 033f73d1b0@xxxxxxxxxxxxxxxxxxxxxxxxxx/
> > https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@l
> > inaro.org/
> >
> > Please let me know if this commit to be merged in previous commit.
> 
> 
> BTW, don't ever use AI to write code or code justifications. I will make note
> of it.
> 

Sorry for the misunderstanding. Will consider this in future. 
However, AI was used to correct spell and grammatic mistakes.

> Best regards,
> Krzysztof

Thank you,

Regards,
Pritam