Re: [PATCH v3 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance

[Andy Shevchenko]

On Sat, Feb 14, 2026 at 11:02:22AM -0600, David Lechner wrote:
> On 2/8/26 9:05 AM, Taha Ed-Dafili wrote:
> > The ADXL345 uses a fixed threshold resolution of 62.5 mg/LSB for
> > event-related registers. Previously, the driver reported raw
> > values without a scale factor.
> > 
> > Implement IIO_EV_INFO_SCALE for all event types to provide the
> > conversion factor (0.612915 m/s^2) as required by the IIO ABI.

...

> > -			BIT(IIO_EV_INFO_ENABLE) |
> > +			BIT(IIO_EV_INFO_ENABLE)	|

What's the difference here?

> > +			BIT(IIO_EV_INFO_SCALE)	|
> >  			BIT(IIO_EV_INFO_VALUE),
> 
> Would be nice to be consistent and put scale after value as the ones
> at the end.

Would it be better other way around to avoid unneeded churn with touching
the last line?

-- 
With Best Regards,
Andy Shevchenko