Re: [PATCH v4 1/2] dt-bindings: clock: xilinx: add description of user monitor interrupt

[Harry Austen]

On Saturday, 14 February 2026 at 20:40, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On Sat, Feb 14, 2026 at 06:10:16PM +0000, Harry Austen wrote:
> > This Xilinx clocking wizard IP core outputs this interrupt signal to
> > indicate when one of the four optional user clock inputs is either
> > stopped, overruns, underruns or glitches.
> >
> > This functionality was only added from version 6.0 onwards, so restrict
> > it to particular compatible strings.
> >
> > Signed-off-by: Harry Austen <hpausten@xxxxxxxxxxxxxx>
> > ---
> > v3 -> v4: Slight rework and rebase, removing Krzysztof's R-b tag
> 
> What exactly changed that you removed the tag? Rebase is not a reason.
> You MUST be here specific about the reason, otherwise why would I like
> to review if next time any rebase and slight rework will drop my tag?

Sorry, good point. By _rework_ I mean that I have removed the allOf. I will
be more specific next time.

> 
> 
> > v2 -> v3: Add Krzysztof's R-b tag
> > v1 -> v2: Fix binding errors by moving interrupts up front, restrict later
> >
> >  .../bindings/clock/xlnx,clocking-wizard.yaml  | 24 ++++++++++++++++++-
> >  1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> > index b497c28e8094f..7688601f1f31b 100644
> > --- a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> > +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> > @@ -38,6 +38,14 @@ properties:
> >        - const: clk_in1
> >        - const: s_axi_aclk
> >
> > +  interrupts:
> > +    items:
> > +      - description: user clock monitor interrupt
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: monitor
> > +
> >    xlnx,static-config:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> > @@ -66,12 +74,24 @@ required:
> >    - xlnx,speed-grade
> >    - xlnx,nr-outputs
> >
> > +if:
> 
> Why isn't this in allOf? Code is fine, but why changing it?

There is only a single if condition, so the allOf is not required. Removed
for simplicity and reduced indentation.

> 
> Best regards,
> Krzysztof
> 
> 

Thanks for the review!
Harry