Re: [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset

[Charles Keepax]

On Wed, Feb 18, 2026 at 11:50:55AM +0100, Pierre-Louis Bossart wrote:
> On 2/18/26 11:14, Richard Fitzgerald wrote:
> > On 17/2/26 23:35, Cole Leavitt wrote:
> >> On systems with CS35L56 SoundWire codecs (e.g. Lenovo ThinkPad P16
> >> Gen3), every boot produces misleading dev_warn() messages:
> >>
> >>    cs35l56 sdw:0:2:01fa:3556:01:0: Slave 2 state check1: UNATTACHED, status was 1
> >>    cs35l56 sdw:0:2:01fa:3556:01:1: Slave 1 state check1: UNATTACHED, status was 1
> >>
> > 
> > Is this really a problem?
> > They are warns, not errors. Nothing in that message says that this is
> > an error, or that it's unexpected. The message is accurate.
> 
> I would just demote the dev_warn() to dev_dbg(). 
> If you look at the original commit, we were chasing weird cases where we have dyndng enabled anyways.
> Also IIRC the problem with 2 devices on the same link was fixed by Richard, wasn't it?
> That would make the dev_warn() even less useful.

I would vote for either this or just leave it as is, doesn't seem
worth the additional complexity to avoid it dynamically.

Thanks,
Charles