Re: [PATCH 2/2] staging: most: dim2: fix error handling in fsl_mx6_enable
From: Dan Carpenter
Date: Thu Feb 19 2026 - 03:19:31 EST
On Mon, Feb 16, 2026 at 08:19:21PM +0000, Artem Lytkin wrote:
> Address several error handling issues in fsl_mx6_enable():
>
> - Replace IS_ERR_OR_NULL() with IS_ERR() for devm_clk_get() return
> value checks, since devm_clk_get() never returns NULL on error.
>
> - Replace hardcoded -EFAULT returns with dev_err_probe() which both
> propagates the actual error code from devm_clk_get() and suppresses
> log messages during probe deferral.
>
> - Remove an unnecessary string indirection in the clk_prepare_enable
> error message.
>
Some of these are unrelated things.
regards,
dan carpenter