Re: [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers
From: Mark Brown
Date: Thu Feb 26 2026 - 06:11:47 EST
On Wed, Feb 25, 2026 at 09:24:32PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 25, 2026 at 07:15:18PM +0000, Mark Brown wrote:
> > On Wed, Feb 25, 2026 at 05:15:59PM +0100, Andy Shevchenko wrote:
> > > - dev_dbg(map->dev, "Writing %zu bytes for %d registers from 0x%x-0x%x\n",
> > > + dev_dbg(map->dev, "Writing %zu bytes for %d registers from %#x-%#x\n",
> > > count * val_bytes, count, base, cur - map->reg_stride);
> > I'm really not convinced this is helping legibility.
> You mean the only this hunk, or the entire patch?
Just that hunk, it's new and unusual, reads less cleanly and I can't
identify any problem it solves.
Attachment:
signature.asc
Description: PGP signature