Re: [PATCH v9 3/7] dt-bindings: media: qcom,x1e80100-camss: Add iommus minItems: 5

[Bryan O'Donoghue]

On 27/02/2026 07:27, Krzysztof Kozlowski wrote:
> On Thu, Feb 26, 2026 at 02:28:44PM +0000, Bryan O'Donoghue wrote:
> > Specify a minimum number of iommus entries. Currently the schema
>
> Why? Your commit msg must explain that.
>
> > requires exactly eight. Add minItems to allow fewer entries while
> > retaining the existing maximum.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> > index 8dbaab16b11d4..f406cf6f8f9c1 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> > @@ -104,6 +104,7 @@ properties:
> >         - const: sf_icp_mnoc
> >   
> >     iommus:
> > +    minItems: 5
> >       maxItems: 8
>
> Same review given to two other such tries from Qualcomm - you need to
> list the items. You know differentiate them, so the items in the list
> have strict order and meaning.

Ah I knew there was something I couldn't quite remember - an 
differentiated list.

Yes np.

---
bod