Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski]

On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
> PMM8654AU is a different PMIC from PMM8650AU, even though both share
> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
> variant.
> 
> The PMM8654AU PON block is compatible with the PMK8350 PON
> implementation, but PMM8654AU also implements additional PON registers

So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
only one? At least it looks, so I expect fixing the last if:then: - you
need to drop contains from PMK8350 if clause and add new if:then: for
PMM8654AU.

Although the binding says "pbs" and here you say "PON".


> beyond the baseline. Use the PMM8654AU naming to match the compatible
> string already present in the upstream pinctrl-spmi-gpio driver, keeping
> device tree and kernel driver naming consistent.

And all this is partially confusing. This is reset/PON, not SPMI Pinctrl
GPIO binding.

Best regards,
Krzysztof