Re: [PATCH net-next v5 3/5] net: cadence: macb: add ethtool EEE support

From: Claudiu Beznea

Date: Sat Feb 28 2026 - 08:34:24 EST




On 2/27/26 17:06, Nicolai Buchwitz wrote:
Implement get_eee and set_eee ethtool ops for GEM as simple passthroughs
to phylink_ethtool_get_eee() and phylink_ethtool_set_eee().

No MACB_CAPS_EEE guard is needed: phylink returns -EOPNOTSUPP from both
ops when mac_supports_eee is false, which is the case when
lpi_capabilities and lpi_interfaces are not populated. Those fields are
only set when MACB_CAPS_EEE is present (previous patch), so phylink
already handles the unsupported case correctly.

Reviewed-by: Théo Lebrun<theo.lebrun@xxxxxxxxxxx>
Signed-off-by: Nicolai Buchwitz<nb@xxxxxxxxxxx>

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>