Re: [PATCH] rust: hrtimer: add active() method to query timer state
From: Alice Ryhl
Date: Sun Mar 01 2026 - 06:32:50 EST
On Sat, Feb 28, 2026 at 04:04:27AM +0100, Miguel Ojeda wrote:
> On Sat, Feb 28, 2026 at 3:23 AM FUJITA Tomonori <tomo@xxxxxxxxxxxx> wrote:
> >
> > Should we use intra-doc links for true/flase? Currently, rust/kernel
> > doesn't seem to use them. Seems that Rust std library isn't consistent
> > on this either.
>
> Maybe... It doesn't matter much either way, obviously.
>
> For simplicity/consistency with other "trivial" items, it may be
> better. On the other hand, it is more painful to type and takes 2
> characters.
>
> This is the entry I have so far for this in my to-be-sent guidelines
> "rules" list:
>
> - Use intra-doc links wherever the link would work (i.e. if ``rustdoc``
> can resolve it), unless doing so would be unreasonably complex or
> verbose. In such a case, use a simple code span instead.
>
> Do so even for trivial types and constants, such as ``i32`` and
> ``true``, as well as for ``Self``.
>
> .. code-block:: rust
>
> /// Returns a new [`Foo`].
>
> Avoid:
>
> .. code-block:: rust
>
> /// Returns a new `Foo`.
I'm not convinced by that. I don't think it's useful for `true` or
`Self` to be links in most cases.
Alice