Re: [PATCH 02/11] scsi: ufs: core: Pass force_pmc to ufshcd_config_pwr_mode() as a parameter

[Can Guo]

Hi Bart,

On 2/28/2026 4:46 AM, Bart Van Assche wrote:
> On 2/27/26 8:07 AM, Can Guo wrote:
> > -    ret = ufshcd_config_pwr_mode(hba, &new_pwr_info);
> > +    ret = ufshcd_config_pwr_mode(hba, &new_pwr_info, 
> > /*force_pmc=*/false);
> Comments like "/*force_pmc=*/" are uncommon in the Linux kernel. Please
> consider introducing an enumeration type for the new argument, e.g.
> enum ufshcd_power_mode_change_policy { DONT_FORCE_PMC, FORCE_PMC }.
> While comments like "/*force_pmc=*/" are not verified at compile time
> (the Clang option -Wdocumentation is disabled as far as I know), the
> type of enumeration labels is checked at compile time.
Thanks for the suggestions, I will make such change in next version.

Best Regards,
Can Guo.
> Thanks,
>
> Bart.