Re: [PATCH v2 1/2] rust: add projection infrastructure
From: Aditya Rajan
Date: Sun Mar 01 2026 - 23:42:17 EST
On Sun Mar 1, 2026 at 5:10 AM PST, Gary Guo wrote:
> On Sat Feb 28, 2026 at 11:38 PM GMT, Aditya Rajan wrote:
>> On Thu Feb 26, 2026 at 7:46 AM PST, Gary Guo wrote:
>
> Good catch!
>
> The code below
>
> if self.end > slice.len() {
> return None;
> }
>
> is rightfully `>` as it's okay to have end being equal to the length. I suppose
> this is what you mean by "somewhere else in the code"?
Yes the second check which i was referring belongs to `core::ops::Range<usize>`, I agree with you
it makes sense for `Range`.
> This one though should indeed be `>=`, and I've obviously messed this one up.
Patch looks good to me once this is fixed for `usize` :)
Thanks
Aditya