Re: [PATCH v10 03/10] gpu: nova-core: falcon: rename load parameters to reflect DMA dependency
From: Eliot Courtney
Date: Sun Mar 01 2026 - 23:54:43 EST
On Sun Mar 1, 2026 at 11:03 PM JST, Alexandre Courbot wrote:
> The current `FalconLoadParams` and `FalconLoadTarget` types are fit for
> DMA loading, but not so much for PIO loading which will require its own
> types. Start by renaming them to something that indicates that they are
> indeed DMA-related.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
> diff --git a/drivers/gpu/nova-core/firmware/booter.rs b/drivers/gpu/nova-core/firmware/booter.rs
> index 2b7166eaf283..d569151982d1 100644
> --- a/drivers/gpu/nova-core/firmware/booter.rs
> +++ b/drivers/gpu/nova-core/firmware/booter.rs
> @@ -19,8 +19,8 @@
> Falcon,
> FalconBromParams,
> FalconFirmware,
> - FalconLoadParams,
> - FalconLoadTarget, //
> + FalconDmaLoadable,
> + FalconDmaLoadTarget, //
> },
I think here but also other files in this patch are not rustfmt'd (e.g.
import ordering here).