Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean

From: Josh Law

Date: Mon Mar 02 2026 - 02:12:40 EST


>>
>> checkpath.pl reported the following warnings:
>>
>> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
>> #81:
>> Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools.
>>
>> WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law <hlcj1234567@xxxxxxxxx>' != 'Signed-off-by: Josh Law <objecting@xxxxxxxxxxxxx>'
>>
>> total: 0 errors, 2 warnings, 0 checks, 9 lines checked
>>
>
> BTW, both of your patches does not apply cleanly.
>
> Regards,
> Kuan-Wei


I think Andrew fixed that....
Including the from lines

V/R