Re: [PATCH 0/3] watchdog: at91/sama5d4: header cleanup and driver refactor

[Balakrishnan.S]

Hi,

On 27/02/26 1:14 pm, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
> 
> On 2/26/26 23:31, Balakrishnan Sambath wrote:
>> This series cleans up the AT91 watchdog header and refactors the
>> sama5d4 watchdog driver.
>>
>> The header reorganization introduces consistent register naming and
>> makes the WDDIS bit handling explicit for modern (SAM9X60, SAMA7G5,
>> SAM9X7) and legacy (SAMA5, AT91SAM9261) SoCs. The driver refactor
>> improves readability and fixes the reset regression introduced by
>> commit 266da53c35fc ("watchdog: sama5d4: readout initial state").
>>
> 
> That is inappropriate as a bug fix. Ther bug fix should come first,
> in a form that can be backported, followed by an optional cleanup.

Thanks for the comments. I'll quickly fix this in v2 as suggested.
> 
> Guenter
> 
>> Andrei Simion (2):
>>    watchdog: at91sam9_wdt.h: Cleanup the header file
>>    watchdog: sama5d4_wdt: Refactor the driver
>>
>> Balakrishnan Sambath (1):
>>    watchdog: at91sam9_wdt: Rename AT91_WDT_WDDIS to AT91_WDT_WDDIS_LEGACY
>>
>>   drivers/watchdog/at91sam9_wdt.c |   8 +-
>>   drivers/watchdog/at91sam9_wdt.h |  65 +++++++------
>>   drivers/watchdog/sama5d4_wdt.c  | 156 ++++++++++++++++----------------
>>   3 files changed, 113 insertions(+), 116 deletions(-)
>>
>