Re: [PATCH] staging: axis-fifo: remove redundant goto end

From: Dan Carpenter

Date: Mon Mar 02 2026 - 04:20:35 EST


On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@xxxxxxxxxxxxx>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aac2c58ef9b3..d83a0fd5b231 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
> &value);
> if (ret) {
> dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
> - goto end;
> + return ret;
> } else if (value != 32) {
> dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
> ret = -EIO;
> - goto end;
> + return ret;

Just return -EIO.

regards,
dan carpenter