Re: [PATCH v1 4/4] page_reporting: change PAGE_REPORTING_DEFAULT_ORDER to -1

From: Yuvraj Sakshith

Date: Mon Mar 02 2026 - 04:50:23 EST


On Mon, Mar 02, 2026 at 10:18:23AM +0100, David Hildenbrand (Arm) wrote:
> > Great. Much more clearer on page_reporting.c 's end.
> >
> > Don't you think on the driver's end:
> >
> > prdev->order = PAGE_REPORTING_USE_DEFAULT; looks clearer? As compared to:
> > prdev->order = PAGE_REPORTING_ORDER_UNSET; ?
> >
> > I'm thinking, why would a driver worry about page_reporting_order being set/unset?
>
> Maybe PAGE_REPORTING_ORDER_UNSPECIFIED ?
>
> In any case, we should use a single flag for this. Everything else will
> be confusing once drivers could use only one of them.
>
> --
> Cheers,
>
> David

Sounds good. Thanks for the suggestion.

Thanks,
Yuvraj