Re: [PATCH v2 04/11] media: qcom: iris: simplify HFI params handling
From: Konrad Dybcio
Date: Mon Mar 02 2026 - 05:15:39 EST
On 2/28/26 4:26 PM, Dmitry Baryshkov wrote:
> Instead of looping over two tables to select the static order of
> functions, call necessary functsions directly in the correct order.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---
[...]
> + } else {
> + ret = iris_hfi_gen1_set_frame_rate(inst, plane);
> + if (!ret)
> + ret = iris_hfi_gen1_set_stride(inst, plane);
> + if (!ret)
> + ret = iris_hfi_gen1_set_resolution(inst, plane);
> + if (!ret)
> + ret = iris_hfi_gen1_set_raw_format(inst, plane);
> + if (!ret)
> + ret = iris_hfi_gen1_set_num_bufs(inst, plane);
Some \n, please?
Otherwise the function calls all seem to match what they've previously
been decoded as
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad