[PATCH 3/5] clocksource/drivers/arm_arch_timer: Drop the arch_counter_get_cnt{p,v}ct_stable() accessors
From: Marc Zyngier
Date: Mon Mar 02 2026 - 05:35:53 EST
Further simplify the counter accessors by eliminating the *_stable()
ones, which serve little purpose at this stage.
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
---
drivers/clocksource/arm_arch_timer.c | 38 +++++++++-------------------
1 file changed, 12 insertions(+), 26 deletions(-)
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 723ba698b8c46..ee21804d6613c 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -100,19 +100,12 @@ static noinstr u64 raw_counter_get_cntpct(void)
return __arch_counter_get_cntpct();
}
-static notrace u64 arch_counter_get_cntpct_stable(void)
+static notrace u64 arch_counter_get_cntpct(void)
{
- u64 val;
- preempt_disable_notrace();
- val = __arch_counter_get_cntpct_stable();
- preempt_enable_notrace();
- return val;
-}
-
-static noinstr u64 arch_counter_get_cntpct(void)
-{
- if (arch_counter_broken_accessors())
- return arch_counter_get_cntpct_stable();
+ if (arch_counter_broken_accessors()) {
+ guard(preempt_notrace)();
+ return __arch_counter_get_cntpct_stable();
+ }
return __arch_counter_get_cntpct();
}
@@ -125,19 +118,12 @@ static noinstr u64 raw_counter_get_cntvct(void)
return __arch_counter_get_cntvct();
}
-static notrace u64 arch_counter_get_cntvct_stable(void)
+static notrace u64 arch_counter_get_cntvct(void)
{
- u64 val;
- preempt_disable_notrace();
- val = __arch_counter_get_cntvct_stable();
- preempt_enable_notrace();
- return val;
-}
-
-static noinstr u64 arch_counter_get_cntvct(void)
-{
- if (arch_counter_broken_accessors())
- return arch_counter_get_cntvct_stable();
+ if (arch_counter_broken_accessors()) {
+ guard(preempt_notrace)();
+ return __arch_counter_get_cntvct_stable();
+ }
return __arch_counter_get_cntvct();
}
@@ -342,10 +328,10 @@ void erratum_set_next_event_generic(const int access, unsigned long evt,
ctrl &= ~ARCH_TIMER_CTRL_IT_MASK;
if (access == ARCH_TIMER_PHYS_ACCESS) {
- cval = evt + arch_counter_get_cntpct_stable();
+ cval = evt + arch_counter_get_cntpct();
write_sysreg(cval, cntp_cval_el0);
} else {
- cval = evt + arch_counter_get_cntvct_stable();
+ cval = evt + arch_counter_get_cntvct();
write_sysreg(cval, cntv_cval_el0);
}
--
2.47.3