Re: [PATCH 1/2] ARM: dts: rockchip: rk3036: Move PHY reset to ethernet-phy node

[Heiko Stuebner]

Hey Fabio,

Am Samstag, 28. Februar 2026, 13:15:52 Mitteleuropäische Normalzeit schrieb Fabio Estevam:
> Hi Heiko,
> 
> On Sat, Feb 28, 2026 at 8:40 AM Heiko Stuebner <heiko@xxxxxxxxx> wrote:
> 
> > please don't send patches that "simply" fix devicetree warnings.
> >
> > As you can see in [0] the driver uses these properties currently.
> > So while this fixes schema warnings, it will break the actual boards.
> >
> > So first of all you'll need to adapt the driver to handle the "official"
> > properties and also provide a fallback in the driver for old devicetrees.
> 
> The rk3066a-rayeager board describes the reset-gpios inside the
> Ethernet PHY node:
> 
> https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/rockchip/rk3066a-rayeager.dts#L155-L157
> 
> Is this broken?

No it isn't :-) .

That's what I get when I try looking at patches on a saturday before
coffee ;-) .

With the reset moving into the phy-node, the phy driver will trigger its
reset itself of course. The arc-mdio also request the reset-gpio as
optional, so the whole thing won't fail if te gpio is not present.

Sorry about the noise, the patch is correct obviously.


Heiko