Re: [PATCH 2/3] hwmon: axi-fan: don't use driver_override as IRQ name

[Nuno Sá]

On Sun, 2026-03-01 at 16:51 -0800, Guenter Roeck wrote:
> On 3/1/26 16:25, Danilo Krummrich wrote:
> > Do not use driver_override as IRQ name, as it is not guaranteed to point
> > to a valid string; use dev_name() instead.
> > 
> > Fixes: 8412b410fa5e ("hwmon: Support ADI Fan Control IP")
> > Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> > ---
> >   drivers/hwmon/axi-fan-control.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
> > index b7bb325c3ad9..ec4bbb104449 100644
> > --- a/drivers/hwmon/axi-fan-control.c
> > +++ b/drivers/hwmon/axi-fan-control.c
> > @@ -507,7 +507,7 @@ static int axi_fan_control_probe(struct platform_device *pdev)
> >   	ret = devm_request_threaded_irq(&pdev->dev, ctl->irq, NULL,
> >   					axi_fan_control_irq_handler,
> >   					IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> > -					pdev->driver_override, ctl);
> > +					dev_name(&pdev->dev), ctl);
> 
> The devm_request_threaded_irq() API documentation says:
> 
> @devname:    An ascii name for the claiming device, dev_name(dev) if NULL
> 
> So NULL should be sufficient.
> 
> Nuno, was there a special reason to use driver_override ?
> 
> 

Not really. That driver was one of my first patches so most likely it was just some
copy pasting. NULL should be fine.

- Nuno Sá