Re: [PATCH 1/2] usb: cdns3: Add USBSSP platform driver support

[Peter Chen]

On 26-03-02 08:31:57, Krzysztof Kozlowski wrote:
> On Mon, Mar 02, 2026 at 11:03:33AM +0800, Peter Chen wrote:
> > -     cdns->gadget_init = cdns3_gadget_init;
> > +     if (device_get_match_data(dev) == &cdnsp_plat)
> > +             cdns->gadget_init = cdnsp_gadget_init;
> > +     else
> > +             cdns->gadget_init = cdns3_gadget_init;
> >
> >       ret = cdns_init(cdns);
> >       if (ret)
> > @@ -317,7 +325,8 @@ static const struct dev_pm_ops cdns3_pm_ops = {
> >
> >  #ifdef CONFIG_OF
> >  static const struct of_device_id of_cdns3_match[] = {
> > -     { .compatible = "cdns,usb3" },
> > +     { .compatible = "cdns,usb3", .data = &cdns3_plat },
> > +     { .compatible = "cdns,usbssp", .data = &cdnsp_plat },
> >       { },
> >  };
> >  MODULE_DEVICE_TABLE(of, of_cdns3_match);
> > @@ -336,6 +345,7 @@ static struct platform_driver cdns3_driver = {
> >  module_platform_driver(cdns3_driver);
> >
> >  MODULE_ALIAS("platform:cdns3");
> > +MODULE_ALIAS("platform:cdnsp");
> 
> You do not need this at all. Fix your DTS or platforms or this
> driver.

Yes, will fix it at v2.

-- 

Best regards,
Peter