Re: [PATCH 07/10] Input: stmfts - add optional reset GPIO support

From: Krzysztof Kozlowski

Date: Mon Mar 02 2026 - 06:17:29 EST


On 02/03/2026 12:04, Konrad Dybcio wrote:
> On 3/1/26 6:51 PM, David Heidelberg via B4 Relay wrote:
>> From: Petr Hodina <petr.hodina@xxxxxxxxxxxxxx>
>>
>> Add support for an optional "reset-gpios" property. If present, the
>> driver drives the reset line high at probe time and releases it during
>> power-on, after the regulators have been enabled.
>>
>> Signed-off-by: Petr Hodina <petr.hodina@xxxxxxxxxxxxxx>
>> Co-developed-by: David Heidelberg <david@xxxxxxx>
>> Signed-off-by: David Heidelberg <david@xxxxxxx>
>> ---
>
> [...]
>
>> + sdata->reset_gpio = devm_gpiod_get_optional(dev, "reset",
>> + GPIOD_OUT_HIGH);
>
> Are you really sure the reset is active-high?

This is not choice of ACTIVE HIGH here. It's initialization to logical
level to keep device in reset state.

Best regards,
Krzysztof