Re: [PATCH v2 03/11] media: qcom: iris: handle HFI params directly

[Dmitry Baryshkov]

On Mon, Mar 02, 2026 at 11:04:44AM +0100, Konrad Dybcio wrote:
> On 2/28/26 4:26 PM, Dmitry Baryshkov wrote:
> > The HFI params are set per the HFI generation, they don't change between
> > different platforms with the same HFI interface.
> 
> Looking at venus/hfi_cmds.c I wouldn't be so sure..
> 
> e.g.
> 
> case HFI_PROPERTY_CONFIG_VENC_MAX_BITRATE:
> case HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER:
> case HFI_PROPERTY_PARAM_BUFFER_ALLOC_MODE:
> case HFI_PROPERTY_PARAM_VENC_SESSION_QP:
> case HFI_PROPERTY_PARAM_VENC_SESSION_QP_RANGE:
> 	/* not implemented on Venus 4xx */
> 	return -ENOTSUPP;

Interesting. I think it's still be better to have iris_hfi_gen1_4xx_ops
rather than having a copy-paste of the same data with minimal changes.
I think it's easier to cross-check two similar functions rather than
sets of tables which then get referenced against a "handler" table.

-- 
With best wishes
Dmitry