Re: [PATCH] spi: spi-dw-dma: fix print error log when wait finish transaction
From: Mark Brown
Date: Mon Mar 02 2026 - 08:38:58 EST
On Mon, Mar 02, 2026 at 02:32:33PM +0300, Vladimir Yakovlev wrote:
> If an error occurs, the device may not have a current message. In this
> case, the system will crash.
>
> In this case, it's better to use dev from the struct host.
Are you sure:
/build/stage/linux/drivers/spi/spi-dw-dma.c: In function ‘dw_spi_dma_wait’:
/build/stage/linux/drivers/spi/spi-dw-dma.c:274:29: error: ‘struct dw_spi’ has no member named ‘host’
274 | dev_err(&dws->host->dev,
| ^~
/build/stage/linux/include/linux/dev_printk.h:110:25: note: in definition of macro ‘dev_printk_index_wrap’
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
/build/stage/linux/drivers/spi/spi-dw-dma.c:274:17: note: in expansion of macro ‘dev_err’
274 | dev_err(&dws->host->dev,
| ^~~~~~~
Attachment:
signature.asc
Description: PGP signature