Re: checkpatch: format of stable@k.o address (was: Re: [PATCH] can: usb: etas_es58x: correctly anchor the urb in the read bulk callback)
From: Greg Kroah-Hartman
Date: Mon Mar 02 2026 - 08:45:03 EST
On Mon, Mar 02, 2026 at 02:11:37PM +0100, Marc Kleine-Budde wrote:
> On 02.03.2026 07:50:58, Greg Kroah-Hartman wrote:
> > On Mon, Mar 02, 2026 at 11:01:48AM +0100, Marc Kleine-Budde wrote:
> > > On 23.02.2026 17:39:20, Greg Kroah-Hartman wrote:
> > > > When submitting an urb, that is using the anchor pattern, it needs to be
> > > > anchored before submitting it otherwise it could be leaked if
> > > > usb_kill_anchored_urbs() is called. This logic is correctly done
> > > > elsewhere in the driver, except in the read bulk callback so do that
> > > > here also.
> > > >
> > > > Cc: Vincent Mailhol <mailhol@xxxxxxxxxx>
> > > > Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > > > Cc: stable <stable@xxxxxxxxxx>
> > >
> > > FYI: checkpatch suggests:
> > > Invalid email format for stable: 'stable <stable@xxxxxxxxxx>', prefer 'stable@xxxxxxxxxx'
> >
> > Checkpatch is wrong here, either is just fine.
>
> That check was introduced by Dwaipayan Ray (Cc'ed) in commit
> fccaebf00e60 ("checkpatch: improve email parsing"), a.k.a.
> v5.11-rc1~133^2~46.
That's some regex hell that I don't want to attempt to fix up, but
really, what I have here is just fine, and "should" be ok by checkpatch
as well.
thanks,
greg k-h