Re: [PATCH] crypto: qce - Remove return variable and unused assignments

[Thorsten Blum]

On 2. Mar 2026, at 13:47, Konrad Dybcio wrote:
> On 3/2/26 12:34 PM, Thorsten Blum wrote:
>> In qce_aead_done(), the return variable 'ret' is no longer used - remove
>> it. And qce_aead_prepare_dst_buf() jumps directly to 'dst_tbl_free:' on
>> error and returns 'sg' - drop the useless 'ret' assignments.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
>> ---
>> drivers/crypto/qce/aead.c | 12 +++---------
>> 1 file changed, 3 insertions(+), 9 deletions(-)
>> [...]
> 
> This could be made much better with a DEFINE_FREE()

I'm not sure this would be an improvement given that 'sg' points into
'rctx->dst_tbl', which is intentionally kept alive after this function.

Thanks,
Thorsten