Re: [PATCH 4/4] arm64: kernel: Fix style in io.c macro

From: Mark Rutland

Date: Mon Mar 02 2026 - 09:55:12 EST


On Sun, Mar 01, 2026 at 12:34:07AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@xxxxxxxxxxxxx>
> ---
> arch/arm64/kernel/io.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/io.c b/arch/arm64/kernel/io.c
> index fe86ada23c7d..ce27fa5d2e37 100644
> --- a/arch/arm64/kernel/io.c
> +++ b/arch/arm64/kernel/io.c
> @@ -17,10 +17,10 @@
> #define memcpy_toio_aligned(to, from, count, bits) \
> ({ \
> volatile u##bits __iomem *_to = to; \
> - const u##bits *_from = from; \
> + const u##bits * _from = from; \
> size_t _count = count; \
> - const u##bits *_end_from = _from + ALIGN_DOWN(_count, 8); \
> - \
> + const u##bits * _end_from = _from + ALIGN_DOWN(_count, 8);\
> +\

There is no style violation here. There's no need to add a space between
'*' and the variable name.

Mark.

> for (; _from < _end_from; _from += 8, _to += 8) \
> __const_memcpy_toio_aligned##bits(_to, _from, 8); \
> if ((_count % 8) >= 4) { \
> --
> 2.43.0
>
>