Re: [PATCH v4 1/9] gpu: nova-core: gsp: sort MsgFunction variants alphabetically
From: Alexandre Courbot
Date: Mon Mar 02 2026 - 09:57:06 EST
On Mon Mar 2, 2026 at 10:47 PM JST, Gary Guo wrote:
> On Mon Mar 2, 2026 at 11:42 AM GMT, Eliot Courtney wrote:
>> There is no particular order required here and keeping them alphabetical
>> will help preventing future mistakes.
>
> Looks like the current order is in increasing opcode order. Granted, currently
> they're generated in bindings and then included as such, but perhaps eventually
> Rust code can be generated directly so the ordering could make sense?
Yes, there are plans to get more code generated and that would include
this as well.
For now alphabetical order makes sense to me as the opcodes come from
the bindings and have no guarantee of being stable.