Re: [PATCH] fuse: replace BUG_ON with WARN_ON and -EBUSY in fuse_ctl_fill_super
From: Miklos Szeredi
Date: Mon Mar 02 2026 - 10:49:14 EST
On Tue, 24 Feb 2026 at 12:56, Yuto Ohnuki <ytohnuki@xxxxxxxxxx> wrote:
>
> Replace BUG_ON(fuse_control_sb) with WARN_ON() that returns -EBUSY.
>
> Currently get_tree_single() prevents duplicate calls to
> fuse_ctl_fill_super(), making this condition unreachable in practice.
> However, BUG_ON() should not be used for conditions that can be handled
> gracefully. Use WARN_ON() to log the unexpected state instead of
> crashing.
NAK, I don't want to add complexity where it has zero benefit.
Thanks,
Miklos