Re: [RFC v3 06/27] rust: add bindings for hash.h

From: Jonathan Cameron

Date: Mon Mar 02 2026 - 11:18:38 EST


On Wed, 11 Feb 2026 13:29:13 +1000
alistair23@xxxxxxxxx wrote:

> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> Make the functions crypto_shash_descsize(), crypto_shash_digestsize()
> and crypto_free_shash() available to Rust.
>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> ---
> rust/bindings/bindings_helper.h | 2 ++
> rust/helpers/hash.c | 18 ++++++++++++++++++
> rust/helpers/helpers.c | 1 +
> 3 files changed, 21 insertions(+)
> create mode 100644 rust/helpers/hash.c
>
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index a067038b4b42..0075c4b62c29 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -34,6 +34,7 @@
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> #include <drm/drm_ioctl.h>
> +#include <crypto/hash.h>

I'm not sure on ordering conventions but this feels odd..
Maybe before the drm inclues?

> #include <kunit/test.h>
> #include <linux/auxiliary_bus.h>
> #include <linux/bitmap.h>
> @@ -60,6 +61,7 @@