Re: [PATCH v6 0/2] Fix compiler warnings/errors in SUNRPC and MACB

From: Sean Chang

Date: Mon Mar 02 2026 - 11:33:53 EST


On Mon, Mar 2, 2026 at 9:26 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Mar 01, 2026 at 06:39:44PM +0100, Andrew Lunn wrote:
> > > - Verified via .lst and nm that both variables (buf) and helper functions
> > > (nlmdbg_cookie2a) are fully optimized out by the compiler when
> > > CONFIG_SUNRPC_DEBUG is disabled.
> >
> > Thanks for doing this bit. It was needed to show my guess was correct.
> >
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> It already has your tag. My Q in v5 still stands: Why is this a series and not
> standalone changes?
>
> Also I just gave a tag, please split these two and send individually.
>

Hi Andy,
Thanks for the suggestion. I have split these into two standalone patches
as you requested:
1. The SUNRPC/NFSD macro simplification [1]
2. The Ethtool/macb redundant guard cleanup [2]

I've also verified the optimization again via .lst files to ensure everything
is clean.

[1] https://lore.kernel.org/all/20260302142931.49108-1-seanwascoding@xxxxxxxxx/
[2] https://lore.kernel.org/all/20260302161818.63651-1-seanwascoding@xxxxxxxxx/
---
Best Regards,
Sean