Re: [PATCH v3 2/2] scripts: generate_rust_analyzer.py: reduce cfg plumbing

[Tamir Duberstein]

On Tue, Jan 27, 2026 at 11:41 AM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> On Tue, Jan 27, 2026 at 10:05 AM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > On Tue, Jan 27, 2026 at 2:56 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
> > >
> > > - rust/Makefile: pass `pin_init{,_internal}-cfgs` from rust/Makefile to
> > >   scripts/generate_rust_analyzer.py.
> > > - scripts/generate_rust_analyzer.py: centralize `cfg` lookup in
> > >   `append_crate` to avoid having to do so for each crate. Remove
> > >   hardcoded `cfg`s for `pin-init{,-internal}` now that these are passed
> > >   from `rust/Makefile`.
> > >
> > > Reviewed-by: Jesung Yang <y.j3ms.n@xxxxxxxxx>
> > > Acked-by: Benno Lossin <lossin@xxxxxxxxxx>
> > > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxxx>
> >
> > I may still take #1 this cycle, but this one you will need either way
> > next cycle, so:
> >
> > Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> >
> > By the way, the commit messages (in the kernel, I know e.g. some GNU
> > projects do it differently) are not typically bullet points, i.e. they
> > usually tell a story and make the points relate to each other, so e.g.
> > it could say that what the first bullet point mentions is needed for
> > the second etc.
> >
> > (I am mentioning this sort of thing since you will be taking commits
> > from others etc.)
>
> Makes sense, thanks. I'll reword into paragraph form on apply.
>
> Thanks!
> Tamir

Applied to `rust-analyzer-next`. Thanks all!