Re: [PATCH net-next v6 0/5] Add AST2600 RGMII delay into ftgmac100
From: Andrew Lunn
Date: Mon Mar 02 2026 - 13:09:16 EST
On Mon, Mar 02, 2026 at 06:24:27PM +0800, Jacky Chou wrote:
> This patch series adds support for configuring RGMII internal delays for the
> Aspeed AST2600 FTGMAC100 Ethernet MACs. It introduces new compatible strings to
> distinguish between MAC0/1 and MAC2/3, as their delay chains and configuration
> units differ.
> The device tree bindings are updated to restrict the allowed phy-mode and delay
> properties for each MAC type. Corresponding changes are made to the device tree
> source files and the FTGMAC100 driver to support the new delay configuration.
>
> This enables precise RGMII timing configuration for AST2600-based platforms,
> improving interoperability with various PHYs
Please add more about backwards compatibility. With just a quick look,
i'm not convinced it is. So it is missing text in the commit message
and probably comments in the code explaining how it works.
Andrew