Re: [PATCH v3 4/5] dma-mapping: Separate DMA sync issuing and completion waiting

[Leon Romanovsky]

On Sun, Mar 01, 2026 at 06:13:16AM +0800, Barry Song wrote:
> From: Barry Song <baohua@xxxxxxxxxx>
> 
> Currently, arch_sync_dma_for_cpu and arch_sync_dma_for_device
> always wait for the completion of each DMA buffer. That is,
> issuing the DMA sync and waiting for completion is done in a
> single API call.
> 
> For scatter-gather lists with multiple entries, this means
> issuing and waiting is repeated for each entry, which can hurt
> performance. Architectures like ARM64 may be able to issue all
> DMA sync operations for all entries first and then wait for
> completion together.
> 
> To address this, arch_sync_dma_for_* now batches DMA operations
> and performs a flush afterward. On ARM64, the flush is implemented
> with a dsb instruction in arch_sync_dma_flush(). On other
> architectures, arch_sync_dma_flush() is currently a nop.
> 
> Cc: Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Cc: Robin Murphy <robin.murphy@xxxxxxx>
> Cc: Ada Couprie Diaz <ada.coupriediaz@xxxxxxx>
> Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
> Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Cc: Tangquan Zheng <zhengtangquan@xxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx> # drivers/xen/swiotlb-xen.c
> Tested-by: Xueyuan Chen <xueyuan.chen21@xxxxxxxxx>
> Signed-off-by: Barry Song <baohua@xxxxxxxxxx>
> ---
>  arch/arm64/Kconfig             |  1 +
>  arch/arm64/include/asm/cache.h |  5 +++++
>  arch/arm64/mm/dma-mapping.c    |  4 ++--
>  drivers/iommu/dma-iommu.c      | 35 ++++++++++++++++++++++++++--------
>  drivers/xen/swiotlb-xen.c      | 24 +++++++++++++++--------
>  include/linux/dma-map-ops.h    |  6 ++++++
>  kernel/dma/Kconfig             |  3 +++
>  kernel/dma/direct.c            |  6 +++++-
>  kernel/dma/direct.h            |  9 +++++++--
>  kernel/dma/swiotlb.c           |  7 ++++++-
>  10 files changed, 78 insertions(+), 22 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>