Re: [PATCH v8 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series
From: Andreas Kemnade
Date: Mon Mar 02 2026 - 14:58:49 EST
On Mon, 23 Feb 2026 08:49:37 -0500
Mithil Bavishi <bavishimithil@xxxxxxxxx> wrote:
> Create common device tree for Samsung Espresso series devices
>
> Create a shared device tree for all variants first.
> Device-specific trees will be added later based on screen size.
>
> Signed-off-by: Mithil Bavishi <bavishimithil@xxxxxxxxx>
[...]
> +&omap4_pmx_wkup {
> + gpio_keys: gpio-keys-pins {
> + pinctrl-single,pins = <
> + OMAP4_IOPAD(0x046, PIN_INPUT | MUX_MODE3)
> + /* sim_cd.gpio_wk3 - EXT_WAKEUP */
> + OMAP4_IOPAD(0x056, | PIN_INPUT | MUX_MODE3)
> + /* fref_clk3_req.gpio_wk30 - VOL_UP */
> + OMAP4_IOPAD(0x05C, | PIN_INPUT | MUX_MODE3)
syntax error. stray | in these two lines. even for small cosmetic
changes, at the very least build it.
Regards,
Andreas