Re: [PATCH] iio: adc: ti-ads1119: Replace IRQF_ONESHOT with IRQF_NO_THREAD

[Jonathan Cameron]

On Mon, 2 Mar 2026 10:15:04 -0600
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> On 3/2/26 10:00 AM, Felix Gu wrote:
> > Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> > without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> > in IRQ request and gives a warning if there is no threaded handler.
> > 
> > Since there is no threaded handler, replace devm_request_threaded_irq
> > with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD.
> > 
> > Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
> > Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> > ---  
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> 
> Although I would swap the order of paragraphs in the commit
> message. The second one is the real problem (so should go first)
> and the first one is just how the problem was found.

I rewrote the commit message along those lines and called
out why it needs IRQF_NO_THREAD.

Applied to the fixes-togreg branch of iio.git and marked for stable.

Given proximity to the patch removing the message, it may be this
will cause some slight mess in linux-next.

Thanks,

Jonathan