Re: [PATCH 24/62] net/cw1200: Fix locking in error paths
From: Bart Van Assche
Date: Mon Mar 02 2026 - 17:12:10 EST
On 3/2/26 3:08 AM, Johannes Berg wrote:
On Mon, 2026-02-23 at 14:00 -0800, Bart Van Assche wrote:
From: Bart Van Assche <bvanassche@xxxxxxx>
cw1200_wow_suspend() must only return with priv->conf_mutex locked if it
returns zero. This mutex must be unlocked if an error is returned. Add
mutex_unlock() calls to the error paths from which that call is missing.
This has been detected by the Clang thread-safety analyzer.
Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx
This, and 25, are part of a larger series and I didn't get a cover
letter, so not sure what's supposed to happen with it.
Peter Zijlstra prefers that subsystem maintainers queue these patches as
one can see here:
https://lore.kernel.org/lkml/20260223220117.GT1282955@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
I plan to resend the patches from this series that have not yet been
queued by subsystem maintainers to the respective maintainers.
Thanks,
Bart.