Re: [PATCH v2 2/3] vfio/ism: Implement vfio_pci driver for ISM devices

[Farhan Ali]

<..snip..>

On 2/24/2026 4:34 AM, Julian Ruess wrote:
> +static const struct pci_device_id ism_device_table[] = {
> +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_IBM,
> +					  PCI_DEVICE_ID_IBM_ISM) },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(pci, ism_device_table);
> +
> +static struct pci_driver ism_vfio_pci_driver = {
> +	.name = KBUILD_MODNAME,
> +	.id_table = ism_device_table,
> +	.probe = ism_vfio_pci_probe,
> +	.remove = ism_vfio_pci_remove,
> +	.driver_managed_dma = true,
> +};

I think we should also define an err_handler callback for the driver? 
IIUC this driver will also be the default driver for passthrough ISM 
devices and it wouldn't support the basic error recovery we do with vfio 
today. I think we can set the err_handler to vfio_pci_core_err_handlers 
as we don't need anything specific for error recovery for ISM devices.

Thanks

Farhan


> +
> +module_pci_driver(ism_vfio_pci_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("vfio-pci variant driver for the IBM Internal Shared Memory (ISM) device");
> +MODULE_AUTHOR("IBM Corporation");
>
> --