Re: [PATCH net-next v2 4/5] net: stmmac: Add write_hw parameter to VLAN filter operations
From: Jakub Kicinski
Date: Mon Mar 02 2026 - 19:09:17 EST
On Mon, 2 Mar 2026 21:59:00 +0000 Ovidiu Panait wrote:
> > I wonder if instead of passing attributes like this around the driver
> > shouldn't simply maintain a flag (or have other way to test) whether
> > the clock to block X is currently enabled? It feels more like a global
> > state / property than trickiness directly related to VLAN config.
>
> I'll drop the write_hw logic and instead just check netif_running()
> directly, to avoid passing attributes around.
SG, tho - be careful with netif_running() in context of open / close
code paths.