Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[Billy Tsai]

Hi Jonathan and Andy,

Sorry, I missed this email thread. I will send v3 with the appropriate Fixes tags.

Thanks

________________________________________
From: Jonathan Cameron <jic23@xxxxxxxxxx>
Sent: Sunday, March 1, 2026 9:41 PM
To: Andy Shevchenko
Cc: Billy Tsai; dlechner@xxxxxxxxxxxx; nuno.sa@xxxxxxxxxx; andy@xxxxxxxxxx; joel@xxxxxxxxx; andrew@xxxxxxxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

On Tue, 28 Oct 2025 12:14:51 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Oct 28, 2025 at 01:41:02PM +0800, Billy Tsai wrote:
> > Ensures the reference voltage bits are cleared in the ADC engine
> > control register before configuring the voltage reference. This
> > avoids potential misconfigurations caused by residual bits.
> >
> > Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
> > ---
>
> It's a v2 and here a changelog is missing.
> No need to resend, just reply with a missing piece.
>

Billy. This one is still outstanding.

I was rather expecting a fixes tag as well.
I'm going to mark it as changes requested in patchwork and stop
tracking it. Hence please send a v3 addressing Andy's comment
and either add a fixes tag or say why one isn't appropriate.


Thanks,

Jonathan