Re: [PATCH 1/5] zram: do not autocorrect bad recompression parameters

[Andrew Morton]

On Tue, 3 Mar 2026 11:59:45 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:

> Sorry for the delay.
> 
> On (26/02/28 12:05), Andrew Morton wrote:
> > On Fri, 27 Feb 2026 17:21:07 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:
> > >
> > 
> > A nice [0/N] overview would be appropriate for a 5-patch series, please.
> 
> Well... I couldn't come up with a nice overview, let me try.
> 
> 
> The series is based on internal discussions.  Minchan looked at
> recompression recently and pointed out a few things that he thought
> were confusing or unexpected/unintuitive, like the fact that zram
> would autocorrect bad recompression priority parameter, or some
> other assumptions that zram made.  I couldn't explain why it was
> like that, and just agreed that it was confusing.  The final patch
> in the series removes chained recompression, which also has some
> unexpected behavior, so I just decided to simplify the code and
> remove that feature.

OK, thanks, I did this:

From: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
Subject: zram: do not autocorrect bad recompression parameters
Date: Fri, 27 Feb 2026 17:21:07 +0900

Patch series "zram: various cleanups".

The series is based on internal discussions.  Minchan looked at
recompression recently and pointed out a few things that he thought
were confusing or unexpected/unintuitive, like the fact that zram
would autocorrect bad recompression priority parameter, or some
other assumptions that zram made.  I couldn't explain why it was
like that, and just agreed that it was confusing.  The final patch
in the series removes chained recompression, which also has some
unexpected behavior, so I just decided to simplify the code and
remove that feature.


This patch (of 5):

Do not silently autocorrect bad recompression priority parameter value and
just error out.

Link: https://lkml.kernel.org/r/bg7ivz7ajiuzdbpv3h6hbptxgmqk5fhwakw4rzk4sz3bczky5a@rde3y352n5ej
Link: https://lkml.kernel.org/r/8a5d53d19a8dbd51d7d81d153676895163e0735e.1772180459.git.senozhatsky@xxxxxxxxxxxx
Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
Suggested-by: Minchan Kim <minchan@xxxxxxxxxx>
Cc: Brian Geffon <bgeffon@xxxxxxxxxx>
Cc: "Christoph Böhmwalder" <christoph.boehmwalder@xxxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Jonathan Corbet <corbet@xxxxxxx>
Cc: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
Cc: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ...