Re: [PATCH v3 0/4] iio: adc: ad799x: modernize resource management

[Archit Anant]

Hi David,

On Mon, Mar 2, 2026 at 9:58 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
> On 3/2/26 7:06 AM, Archit Anant wrote:
> > This series modernizes the ad799x driver by converting all resource
> > management to use the devm_ infrastructure, ultimately allowing for the
> > complete removal of the ad799x_remove() function and simplifying the
> > error paths in probe.
> >
> > This series addresses the feedback from v2, where the changes were
> > squashed into a single patch, by splitting the logical steps into
> > individual, bisectable commits. It also incorporates feedback regarding
> > the safe ordering of regulator disablement and IIO device unregistration.
> >
> > Changes in v3:
> > - Split the monolithic v2 patch into 4 logical commits as requested by
> >   Andy Shevchenko.
> >
> > Changes in v2:
> > - Incorporated feedback from David Lechner to eliminate dynamic buffer
> >   allocation.
> > - Incorporated feedback from Jonathan Cameron regarding the ordering
> >   hazards of mixing devm and manual teardown, utilizing devm_add_action
> >   and voltage caching.
> >
>
> I just reviewed v2 because I didn't see there was a v3 yet. This is why
> we ask to wait ideally 1 week, but at a few days before sending a new
> revision.

I agree, I should have waited longer before sending the next revision.
After Andy's feedback on v2, I realized that the monolithic patch was
difficult to review and wanted to get the split series out as quickly as
possible to save reviewers' time. However, I see now that sending it too
fast caused a different kind of confusion.

>
> Some of those comment will still apply to v3.

I will wait a few days to collect all feedback on v3 before preparing
and sending v4.
Thanks for the patience and the review!

-- 
Sincerely,
Archit Anant